Fixing our large timing discrepancy issue#1412
Merged
AnomalRoil merged 3 commits intomasterfrom Apr 25, 2025
Merged
Conversation
Member
Author
|
Fixes #1093 |
CluEleSsUK
previously approved these changes
Apr 25, 2025
Contributor
|
think it needs some linter love but then good to go |
CluEleSsUK
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've discovered the culprit for our relatively large timing discrepancy in beacon production!
We were starting our ticker after waiting a given number of seconds without distinguishing whether the current second was already ticking or not. This PR adds extra tracing information and fixes the issue by relying on
clock.Until, which is precise down to the nanosecond unlike how previous "second" resolution.This PR brings a 97% decrease in beacon aggregation latency when doing local tests.