Skip to content

Comments

Fixing panic in callback called twice for next beacon#1391

Merged
AnomalRoil merged 7 commits intomasterfrom
easy/waitongrpc
Sep 25, 2024
Merged

Fixing panic in callback called twice for next beacon#1391
AnomalRoil merged 7 commits intomasterfrom
easy/waitongrpc

Conversation

@AnomalRoil
Copy link
Member

This is a more stupid way of doing it. I didn't want to do that initially because I'm worried about the aggregation latency of ~400-700ms conflicting with the sleep, so using a callback which is guaranteed to be called when the next round is produced seemed much cleaner.

I'm tempted to do a +1 on the targetTime to mitigate for that.

Okay, ignore my first commit, I reverted to a callback to avoid the above problem, but now it's got a mutex and the impossible $2^{-128}$ edge case is removed.
Also changed the way the context and cancellations are handled.
All edgecases should also be covered now.

@AnomalRoil AnomalRoil merged commit fc04e5f into master Sep 25, 2024
@AnomalRoil AnomalRoil deleted the easy/waitongrpc branch September 25, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants