Update BN254 DST to refer to the SVDW mapping#1385
Merged
CluEleSsUK merged 2 commits intodrand:masterfrom Jul 31, 2024
Merged
Conversation
azixus
requested review from
AnomalRoil,
CluEleSsUK and
GlacierWalrus
as code owners
GlacierWalrus
approved these changes
Jul 31, 2024
Collaborator
GlacierWalrus
left a comment
GlacierWalrus
left a comment
There was a problem hiding this comment.
lgtm but I'm not sure I'd know if something was amiss here 😅
CluEleSsUK
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current DST of the BN254 scheme, the mapping is referred to as SSWU (Simplified Shallue-van de Woestijne-Ulas).
However, the implemented mapping in kyber follows the SVDW (Shallue-van de Woestijne) method.
This PR updates the DST from
BLS_SIG_BN254G1_XMD:KECCAK-256_SSWU_RO_NUL_toBLS_SIG_BN254G1_XMD:KECCAK-256_SVDW_RO_NUL_and the test vectors of thebls-bn254-unchained-on-g1scheme.