Repository navigation
Commit 8881516
Parquet: Restore NameMapping.empty() default after removing NETFLIX_UNSAFE branch
The prior 1.11 logic in `Parquet.ReadBuilder` had three branches when picking
the name mapping for a vectorized read:
1. caller-provided nameMapping → use it
2. `NETFLIX_UNSAFE_PARQUET_ID_FALLBACK_ENABLED=true` → use null (unsafe
fallback to position-based field resolution)
3. default → use `NameMapping.empty()` (safe)
PR apache#16449 removed the deprecated NETFLIX_UNSAFE branch (case 2) but
collapsed the default to `null` rather than `NameMapping.empty()`, making
unsafe position-based resolution the new default. That contradicts the
PR description ("always use NameMapping.empty() (the safe default)") and
silently regresses readers that don't supply an explicit mapping.
Restore the safe default by using `NameMapping.empty()` when no mapping
is provided.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>1 parent 696b97b commit 8881516
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1489 | 1489 | | |
1490 | 1490 | | |
1491 | 1491 | | |
1492 | | - | |
| 1492 | + | |
1493 | 1493 | | |
1494 | 1494 | | |
1495 | 1495 | | |
| |||
0 commit comments