rafs: fix bug in InodeWrapper::is_sock()#1630
Merged
imeoer merged 1 commit intodragonflyoss:masterfrom Sep 27, 2024
Merged
Conversation
We incorrectly use is_dir() to check if a file is a socket. This patch fixes it. Signed-off-by: Yifan Zhao <[email protected]>
SToPire
requested review from
hsiangkao,
imeoer and
power-more
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1630 +/- ##
==========================================
- Coverage 61.28% 61.28% -0.01%
==========================================
Files 146 146
Lines 48156 48156
Branches 46123 46123
==========================================
- Hits 29514 29510 -4
- Misses 17084 17085 +1
- Partials 1558 1561 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We incorrectly use is_dir() to check if a file is a socket. This patch fixes it.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply: