fix(dracut-install): do not fail when SOURCE is optional and missing

pvalena · johannbg · commit bd1a5ca9ae9e · 2022-04-04T08:00:10.000Z
When running dracut-install with '-o' (optional source), and nullglob
at the same time, when all of the arguments evaluate &lt;null&gt;, dracut-install
should not fail even when the source is not specified.
diff --git a/src/install/dracut-install.c b/src/install/dracut-install.c
@@ -1175,8 +1175,12 @@ static int parse_argv(int argc, char *argv[])
         }
 
         if (!optind || optind == argc) {
-                log_error("No SOURCE argument given");
-                usage(EXIT_FAILURE);
+                if (!arg_optional) {
+                        log_error("No SOURCE argument given");
+                        usage(EXIT_FAILURE);
+                } else {
+                        exit(EXIT_SUCCESS);
+                }
         }
 
         return 1;

Original file line number	Diff line number	Diff line change
`@@ -1175,8 +1175,12 @@ static int parse_argv(int argc, char *argv[])`
`1175`	`1175`	`}`
`1176`	`1176`
`1177`	`1177`	`if (!optind \|\| optind == argc) {`
`1178`		`- log_error("No SOURCE argument given");`
`1179`		`- usage(EXIT_FAILURE);`
	`1178`	`+ if (!arg_optional) {`
	`1179`	`+ log_error("No SOURCE argument given");`
	`1180`	`+ usage(EXIT_FAILURE);`
	`1181`	`+ } else {`
	`1182`	`+ exit(EXIT_SUCCESS);`
	`1183`	`+ }`
`1180`	`1184`	`}`
`1181`	`1185`
`1182`	`1186`	`return 1;`