Closed
Conversation
Only the "old school build" test uses --disable-dependency-generation. This is also tested on both Travis and AppVeyor, so we have good release coverage checking of this option.
The $(wildcard *.h) should only be there with --disable-dependency-generation, since otherwise gcc -MM will be determining exactly which header files should be checked.
It's the macOS default installed version still. The dependency generation inadvertently relies on behaviour introduced in GNU make 3.82 a decade ago. The fix in otherlibs/systhreads/Makefile also corrects missing NATIVE_CPPFLAGS when generating st_stubs.n.d, so st_stubs.n.o now correctly depends on caml/stacks.h instead of caml/stack.h
It's a subtly broken thing to do, as discovered on the ARM workers on Inria's CI.
No longer required, and in fact causing breakages now that -MG isn't used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.