feat: add config for forced multiline named imports/exports#473
feat: add config for forced multiline named imports/exports#473dsherret merged 5 commits intodprint:mainfrom
Conversation
|
Spent some time thinking about it, and I feel like it shouldn't be a boolean, but two options, one which allows |
I think you're right. I think it's ok to land this as a boolean for now though. |
dsherret
changed the title
dsherret
changed the title
dsherret
left a comment
dsherret
left a comment
There was a problem hiding this comment.
LGTM! I don't see any issues :)
I made the config name shorter.
In the interest of time, let's land this one and then if you'd like you can submit a follow up PR with it not being a boolean. I think maybe something like "always" | "multiple" | "something for this being off that I can't think of... maybe just 'off' or 'lineWidth'...not sure".
|
Thanks for reviewing! (These PRs are the only Rust I've actually written, so, shocked I don't have more trouble.) |
2 participants
For #453.
This just does imports/exports; I'm not totally confident in the implementation or its naming, either. I just thought I'd throw an idea out there.