Repository navigation
Commit 173c9d9
committed
Fix error reporting for nested rules.
This modifies the fix in f259ff, which wasn't quite
right. We were incorrectly rolling back the `errpos` field
when rules failed, which would lead to errors being
reported as having happened at the beginning of a rule,
rather than at the spot where something actually
happened.
In debugging this, I realized that part of the problem is
that error reporting for semantic predicate failures doesn't
quite work right, so I've filed a new bug for that and
updated the tests to be clearer.
See dpranke/pyjson5#26 and
#3 for more on
this.1 parent 7ff67f0 commit 173c9d9
2 files changed
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | | - | |
188 | | - | |
189 | 187 | | |
190 | 188 | | |
191 | 189 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
281 | 281 | | |
282 | 282 | | |
283 | 283 | | |
284 | | - | |
285 | | - | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
286 | 292 | | |
287 | 293 | | |
288 | 294 | | |
289 | | - | |
| 295 | + | |
290 | 296 | | |
291 | 297 | | |
292 | 298 | | |
293 | 299 | | |
294 | | - | |
| 300 | + | |
295 | 301 | | |
296 | 302 | | |
297 | 303 | | |
| |||
0 commit comments