Skip to content

Share jsdom adapter configuration per document - #213

Merged
jdalton merged 4 commits into
dperini:masterfrom
jdalton:feat/jsdom-shared-engine
Sep 6, 2026
Merged

jdalton merged 4 commits into
dperini:masterfrom
jdalton:feat/jsdom-shared-engine

Conversation

@jdalton

@jdalton jdalton commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Add DOMSelector.configure(window, options) and DOMSelector.use(window, engine) for setup before the first query or stylesheet match. Compatible installed copies share one document engine. Keep DOM errors throwing and stylesheet errors contained.
  • Add isolated adapter unit tests and installed-package integration coverage.
  • Group tests under test/repo/unit, test/repo/integration, and test/repo/e2e; move development scripts under scripts/repo and update commands, CI, and documentation.
  • Fix the existing hexadecimal identifier regression, with class whitespace safeguards and browser comparisons in the WPT harness.

Validation

  • Formatting, lint, type checks, and generated documentation pass.
  • 387 Node tests pass; 3 browser-only tests are covered separately.
  • 22 installed-package adapter tests pass with pnpm.
  • 43 WPT pages pass against the existing expectation baseline. Combined engine/WPT and adapter/Node line coverage is 75%.

@jdalton
jdalton merged commit cececbf into dperini:master Sep 6, 2026
jdalton added a commit that referenced this pull request Sep 17, 2026
* Add document-scoped jsdom engine configuration

* Group repository tests and development scripts

* Test shared adapter setup and verify relocated runners

* Compile escaped identifiers without changing class token boundaries
jdalton added a commit that referenced this pull request Sep 17, 2026
Consolidated commits:
- d8158d9 Read the last token of a selector that ends in a nested pseudo-class (#182)
  Original author: John-David Dalton <[email protected]>
- e0087aa Keep enabled and disabled states complementary (#190)
  Original author: John-David Dalton <[email protected]>
- 3526e0c Use agent-aware test reporters
  Original author: jdalton <[email protected]>
- 0b43903 Share jsdom adapter configuration per document (#213)
  Original author: John-David Dalton <[email protected]>
- 4fe8b2c fix: correct form states, defined elements and relative has anchors
  Original author: John-David Dalton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant