Fix button mapping icons for Nintendo controllers #271
Conversation
| let button = holder.button_rects.get(&Button::North).unwrap()[3].clone(); | ||
| holder.button_rects.get_mut(&Button::North).unwrap()[3] = holder.button_rects.get(&Button::West).unwrap()[3]; | ||
| holder.button_rects.get_mut(&Button::West).unwrap()[3] = button; | ||
| let button = holder.button_rects.get(&Button::South).unwrap()[3].clone(); | ||
| holder.button_rects.get_mut(&Button::South).unwrap()[3] = holder.button_rects.get(&Button::East).unwrap()[3]; | ||
| holder.button_rects.get_mut(&Button::East).unwrap()[3] = button; |
There was a problem hiding this comment.
This makes like no sense at all? There's no condition for Nintendo controllers and this has the same effect as swapping rectangle definitions in code you've removed.
There was a problem hiding this comment.
Nintendo controller mapping comes from rect index 3, which is the index of the buttons I'm swapping. The other indexes, 0 through 2 are left unmodified. They would be changed as well if I simply swapped definitions in the old code.
The current code creates a set of 4 Rects for each Button in the hashmap. (see GampadConsts::rects) This code assumes the buttons for each system will be in the same order, but if this were the case, the buttons for the Nintendo controllers would be reversed. Swapping the buttons in the image file isn't an option because d-rs loads the button image assets from the Nicalis ports, which can't be distributed with the engine. The game has to bend to accommodate those assets.
2 participants
No description provided.