Dynamic graphs and nodes #228
Conversation
Some styling and naming.
Modified NodeWrapper Set* to diff instead of delete all on assignment. Added blank node support and null support to NodeWrapper Set*.
Removes failing old test.
Trying out new testing structure.
Default subject base uri to graph base uri. Expose subject nodes only. Some renaming. Smarter filtering of qnames.
Graph wrapper supports setting dictionary values. Simplifies object serialization.
Add support for wrapper indexing.
This reverts commit b1dfd2f.
Rename wrappers to dynamic. Support qnames in dynamic property names. New node tests. Remove old tests.
Adds dynamic graph blank nodes method. Validates uri and blank only for dynamic node. Adds support for indexing graph with empty string.
Implement mamber names. Remove old code. Adjust tests.
Assorted cleanup.
Helper methods are now extension methods.
All member bodies expanded. Exceptions made more specific. Some parameters renamed. Some interface implementations made explicit.
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 48.44% 49.13% +0.69%
==========================================
Files 767 788 +21
Lines 56561 57201 +640
==========================================
+ Hits 27399 28107 +708
+ Misses 29162 29094 -68
Continue to review full report at Codecov.
|
Problem was new line differences.
|
This looks great @langsamu - I think it is the kind of thing that definitely helps the use of RDF in a .NET environment and I'd be really happy to accept this into the DNR code-base. Its a lot to review here so I'm going to have a bit of a play around with the code today and if I have any other feedback I'll add it here. Two initial comments though: Can you add a page or two to the wiki that documents this stuff. I'd like to link that in then to the sequence on Getting Started, because I think for a lot of developers using the dynamic API might be preferable to using the low-level API if they can get their head around the property name to URI mappings. I can see how you could use this API over the result of a SPARQL CONSTRUCT / DESCRIBE query, which I think is a massive benefit. I wonder if adding a bit more code to enable a tabular result set from a SELECT query to be mapped to an enumeration of dynamic objects might also be something worth considering so that there isn't a sudden disconnect from the dyamic API when doing a SPARQL query. |
|
Thanks for the comments @kal.
|
|
Thanks @langsamu - I'm happy to merge the PR as it stands, but the docs probably need a bit more work. I've started to add a bit more "how to" documentation to the start before diving into the theory as I think it would be good to just provide some quick start documentation for the API. What I've added so far is based on the unit tests and examples, but if you could give it a quick sense-check to make sure I haven't misrepresented anything that would be great! Still need to add documentation about Contains and ContainsKey and about accessing SPARQL result sets. |
|
BTW - I've merged the docs to the DNR wiki too. |
Adds test for wrapper node specialisations.
Inspired by @mattrayner's GROM, which is used extensively in @ukparliament's new website. Used in this ASP.NET Core SKOS viewer for Parliament's Controlled Vocabulary
Dynamic graphs and nodes
This feature adds read/write dictionary and dynamic capabilities to
IGraphandINodeby implementingIDictionary<>andIDynamicMetaObjectProvideronWrapperGraphandWrapperNode.Examples
Tests in the Example class (1, 2) give an overview of feature details.
I'd appreciate feedback and help making this PR better.