Arcade update + use new pool-providers.yml to pick the build pool #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premun
reviewed
Oct 24, 2022
premun
approved these changes
Oct 24, 2022
Member
|
All of the line endings got changed to CRLF, probably because you changed it on a Windows machine that didn't have the git settings to keep line endings. I don't think we should've merged this as is since it messes up history a bit :) |
Member
|
Ah, yeah, we shouldn't have. I thought this was Arcade giving us the files like that so I approved. |
Member
|
No big deal, we can leave it as is. |
Member
Author
I knew something was off but I couldn't figure it out. I have git set as "checkout as-is / commit as-is" and this has only happened on the Xharness repo. Future dependency flows will overwrite it back, if they do. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates Arcade for this branch and introduces the ability to automatically pick pool provider based on branch. See files changed outside of the eng/common folder for what changed.
Not sure why there are such a large number of whitespace changes but this should go away in future arcade updates.
Test runs:
Main CI: https://dnceng.visualstudio.com/internal/_build/results?buildId=2026946&view=logs&s=e6b610b4-9a0b-53ae-ef5f-811cf6e05977
CodeQL: https://dnceng.visualstudio.com/internal/_build/results?buildId=2026949&view=results