Fix SpecialFolder.Personal usage#948
Merged
premun merged 1 commit intodotnet:mainfrom Sep 14, 2022
Merged
Conversation
SpecialFolder Personal is the same value as MyDocuments. I am proposing to obsolete/deprecate SpecialFolder.Personal in dotnet/runtime#75563. Since these two names have the same underlying value, it is more understandable/readable to use MyDocuments in code. This way readers fully understand what folder is being referenced. Changing Personal to MyDocuments here.
premun
approved these changes
Sep 14, 2022
Member
|
The failure here is unrelated, merging |
akoeplinger
added a commit
that referenced
this pull request
Jul 4, 2024
The value changed in .NET 8: https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/8.0/getfolderpath-unix#change-description This was touched in #948 but the change is wrong, mlaunch expects this file to be in $HOME: https://github.com/xamarin/maccore/blob/bd1f42be1995b8501542a90671aa668771f1b3a0/tools/mlaunch/Xamarin.Hosting/Xamarin.Launcher/controller-device.cs#L341
akoeplinger
added a commit
that referenced
this pull request
Jul 4, 2024
#1228) The value changed in .NET 8: https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/8.0/getfolderpath-unix#change-description This was touched in #948 but the change is wrong, mlaunch expects this file to be in $HOME: https://github.com/xamarin/maccore/blob/bd1f42be1995b8501542a90671aa668771f1b3a0/tools/mlaunch/Xamarin.Hosting/Xamarin.Launcher/controller-device.cs#L341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpecialFolder Personal is the same value as MyDocuments. I am proposing to obsolete/deprecate SpecialFolder.Personal in dotnet/runtime#75563. Since these two names have the same underlying value, it is more understandable/readable to use MyDocuments in code. This way readers fully understand what folder is being referenced.
Changing Personal to MyDocuments here.