Correctly wait for completion of DelegatingXmlCreationSink #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With dotnet/runtime#62501 we were only waiting for completion of the DelegatingExecutionSummarySink, not the DelegatingXmlCreationSink. Since DelegatingXmlCreationSink doesn't provide a callback when testing is done we need to add a wrapper execution sink that listens for the ITestAssemblyFinished message. Fixes dotnet#903
premun
approved these changes
Jun 14, 2022
akoeplinger
added a commit
to akoeplinger/xharness
that referenced
this pull request
Jul 25, 2022
Follow the same approach as in dotnet#906 Should fix dotnet#924
akoeplinger
added a commit
to akoeplinger/xharness
that referenced
this pull request
Jul 25, 2022
Follow the same approach as in dotnet#906 Should fix dotnet#924
akoeplinger
added a commit
to akoeplinger/xharness
that referenced
this pull request
Jul 25, 2022
Follow the same approach as in dotnet#906 Should fix dotnet#924
akoeplinger
added a commit
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dotnet/runtime#62501 we were only waiting for completion of the DelegatingExecutionSummarySink, not the DelegatingXmlCreationSink.
Since DelegatingXmlCreationSink doesn't provide a callback when testing is done we need to add a wrapper execution sink that listens for the ITestAssemblyFinished message.
I also noticed we were using MemoryStream.ToArray() when sending the results which creates an additional copy that we can avoid.
Fixes #903