Skip to content

Unify ADB retry logic and exit codes; retry adb start-server #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
premun merged 14 commits into from
Mar 2, 2022
Merged

Unify ADB retry logic and exit codes; retry adb start-server #825

premun merged 14 commits into from
Mar 2, 2022

Conversation

@premun
Copy link
Member

@premun premun commented Feb 24, 2022 •
edited
Loading

There are several changes here:

  • Unified retry loops in AdbRunner as we do retry in many places
  • Start retrying adb start-server (addresses Starting the ADB server fails #822)
  • Unified exception handling in Android commands (code deduplication)
  • Return DEVICE_NOT_FOUND instead of ADB_ENUMERATION_FAILURE as the latter implies something is wrong with ADB (but it's just device missing)
  • Introduced new exit code ADB_FAILURE for when ADB commands fail
  • Improve how we handle ADB failures

@premun premun requested review from dkurepa and lpatalas February 24, 2022 13:14
@premun premun changed the title Add retries to adb start-server & unify retry logic in AdbRunner Unify retry logic in AdbRunner & add retries to adb start-server Feb 24, 2022
@premun premun changed the title Unify retry logic in AdbRunner & add retries to adb start-server Unify ADB retry logic and exit codes; retry adb start-server Feb 25, 2022
@premun premun requested a review from MattGal February 25, 2022 13:21
@premun premun mentioned this pull request Feb 28, 2022
Merged
lpatalas
lpatalas reviewed Feb 28, 2022
View reviewed changes
@premun premun requested a review from lpatalas March 1, 2022 15:42
@premun premun merged commit 9d48f6d into dotnet:main Mar 2, 2022
@premun premun deleted the prvysoky/retries branch March 2, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurepa dkurepa Awaiting requested review from dkurepa

@MattGal MattGal Awaiting requested review from MattGal

1 more reviewer

@lpatalas lpatalas lpatalas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@premun @lpatalas