Fix configuration of test filtering in Android application test runner #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
force-pushed
the
fixConfigureRunner
branch
from
51346a1 to
0c7ebeb
Compare
The Android and iOS application entry points were running the tests and then trying to configure filters for the test run afterwards.
akoeplinger
reviewed
Mar 24, 2021
src/Microsoft.DotNet.XHarness.TestRunners.Common/ApplicationEntryPoint.cs
Outdated
Show resolved
Hide resolved
premun
approved these changes
Mar 29, 2021
Member
Author
|
@premun do you think this is ready to merge, or do we need to wait for other reviews? I'd like to get this in soon, since it really helps with the inner dev loop for running Android tests. (I don't have merge permissions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @steveisok @jkoritzinsky