Use latest version of ASP.NET Core via FrameworkReference instead of nuget #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nuget We were pulling in Microsoft.AspNetCore 2.2 via a nuget PackageReference, but after upgrading Microsoft.Extensions.Logging in dotnet#315 we saw the following error when using the "wasm test-browser" command: ``` �[41m�[30mfail�[39m�[22m�[49m: Microsoft.AspNetCore.Server.Kestrel[0] Heartbeat.OnHeartbeat System.TypeLoadException: Could not load type 'Microsoft.Extensions.Primitives.InplaceStringBuilder' from assembly 'Microsoft.Extensions.Primitives, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. at Microsoft.Net.Http.Headers.DateTimeFormatter.ToRfc1123String(DateTimeOffset dateTime, Boolean quoted) at Microsoft.Net.Http.Headers.HeaderUtilities.FormatDate(DateTimeOffset dateTime, Boolean quoted) at Microsoft.Net.Http.Headers.HeaderUtilities.FormatDate(DateTimeOffset dateTime) at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.DateHeaderValueManager.SetDateValues(DateTimeOffset value) at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.DateHeaderValueManager.OnHeartbeat(DateTimeOffset now) at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.Heartbeat.OnHeartbeat() ``` The reason is that the newer version of Microsoft.Extensions.Primitives removed InplaceStringBuilder. Instead of using an old ASP.NET we can use the one in the framework instead, which is what's recommended since .NET Core 3.0
radical
approved these changes
Oct 2, 2020
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
Ah! I had a local fix but this looks better 👍
premun
approved these changes
Oct 2, 2020
akoeplinger
force-pushed
the
fix-aspnet
branch
5 times, most recently
from
93a88e9 to
c53699f
Compare
akoeplinger
added a commit
to dotnet/arcade
that referenced
this pull request
Oct 2, 2020
This allows getting the Microsoft.AspNetCore.App shared framework instead of just Microsoft.NETCore.App. Helps to unblock dotnet/xharness#324.
akoeplinger
force-pushed
the
fix-aspnet
branch
from
c53699f to
fe4ac5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were pulling in Microsoft.AspNetCore 2.2 via a nuget PackageReference, but after upgrading Microsoft.Extensions.Logging in #315 we saw the following error when using the "wasm test-browser" command:
The reason is that the newer version of Microsoft.Extensions.Primitives removed InplaceStringBuilder.
Instead of using an old ASP.NET we can use the one in the framework instead, which is what's recommended since .NET Core 3.0