Skip to content

[wasm][tests] Remove extra newline from output, making it a bit tighter #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 1 commit into from
Sep 28, 2020
Merged

[wasm][tests] Remove extra newline from output, making it a bit tighter #314

akoeplinger merged 1 commit into from
Sep 28, 2020

Conversation

@radical
Copy link
Member

@radical radical commented Sep 27, 2020

This changes the output from:

dbug: test-browser[0]
      [FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpProtocolTests.GetAsync_InvalidStatusLine_ThrowsExceptionOnSocketsHttpHandler(responseString: "HTTP/1.1 200\tOK")

dbug: test-browser[0]
      System.PlatformNotSupportedException : System.Net.Sockets is not supported on this platform.

.. to ..

dbug: test-browser[0]
      [FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpProtocolTests.GetAsync_InvalidStatusLine_ThrowsExceptionOnSocketsHttpHandler(responseString: "HTTP/1.1 200\tOK")
dbug: test-browser[0]
      System.PlatformNotSupportedException : System.Net.Sockets is not supported on this platform.

@radical
[wasm][tests] Remove extra newline from output, making it a bit tighter
f2da0d4 
This changes the output from:

```
dbug: test-browser[0]
      [FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpProtocolTests.GetAsync_InvalidStatusLine_ThrowsExceptionOnSocketsHttpHandler(responseString: "HTTP/1.1 200\tOK")

dbug: test-browser[0]
      System.PlatformNotSupportedException : System.Net.Sockets is not supported on this platform.

```

.. to ..

```
dbug: test-browser[0]
      [FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpProtocolTests.GetAsync_InvalidStatusLine_ThrowsExceptionOnSocketsHttpHandler(responseString: "HTTP/1.1 200\tOK")
dbug: test-browser[0]
      System.PlatformNotSupportedException : System.Net.Sockets is not supported on this platform.
```
@radical
Copy link
Member Author

radical commented Sep 27, 2020

/cc @lewing @CoffeeFlux @akoeplinger

@radical
Copy link
Member Author

radical commented Sep 27, 2020

Do we want to have some way to get just a regular Xunit like output? IOW, with no dbug:.. lines. Is there some way to do that already (I couldn't find it)? If not, then what would it look like from a user pov, eg. command line arg?

CoffeeFlux
CoffeeFlux approved these changes Sep 28, 2020
View reviewed changes
Copy link

@CoffeeFlux CoffeeFlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akoeplinger
Copy link
Member

akoeplinger commented Sep 28, 2020 •
edited
Loading

Do we want to have some way to get just a regular Xunit like output? IOW, with no dbug:.. lines.

Yeah I've got many requests for outputting just the failures and not everything, I have a stash somewhere which implements this which I need to dust off :)

We can't easily get rid of the separate dbug: lines since they're hardcoded in Microsoft.Extensions.Logging but with my change above we'd have a separate wasm-console.log file which contains the plain stdout.

@akoeplinger akoeplinger merged commit 45a9633 into dotnet:master Sep 28, 2020
@akoeplinger akoeplinger mentioned this pull request Sep 28, 2020
Merged
@CoffeeFlux
Copy link

CoffeeFlux commented Sep 28, 2020

Regarding

We can't easily get rid of the separate dbug: lines since they're hardcoded in Microsoft.Extensions.Logging but with my change above we'd have a separate wasm-console.log file which contains the plain stdout.

Can we open an issue about that specifically? Even if it's non-trivial, it would be really nice to see them go away one day.

@akoeplinger
Copy link
Member

akoeplinger commented Sep 28, 2020

Yeah, this seems to be a long-standing request: https://stackoverflow.com/questions/44230373/is-there-a-way-to-format-the-output-format-in-net-core-logging

Looks like we could write our own custom log format, I'll take a look at that.

@radical radical deleted the wasm-tests-remove-newline branch September 29, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

+1 more reviewer

@CoffeeFlux CoffeeFlux CoffeeFlux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radical @akoeplinger @CoffeeFlux