[wasm] Add a new wasm webserver command#1001
Conversation
- ends after a timeout, or can be killed.
- Convert all the command line arguments to TestWebServerOptions. This also helps to avoid having to add new method arguments to WebServer to add more options. - And add a --web-server-use-default-files option that serves files like `index.html` and `default.html` by default.
radical
added
enhancement
pavelsavara
left a comment
pavelsavara
left a comment
There was a problem hiding this comment.
LGMT. Could you please explain where/how this would be used ? Thanks.
|
Do we want to merge it with the simple server from the runtime repo? |
Do you mean the webserver in the app host? |
Do you mean use this xharness instead of simple server ? Pros: one codebase, consistent behavior We also want to have blazor like server as part of the host. Should we replace simple server with that ? |
Prompted by need to run blazor published apps by starting a webserver for them. See dotnet/runtime#82748 |
|
Another consideration is that the web server in the host, should be rather production grade. xharness is rather test utility. |
Yep, I don't think it is worth trying to share the webserver here, and in the apphost. And I'm looking at this as for tests, and a generic-ish one (though it has some wasm specific bits, which is fine). |
|
Failures are unrelated. |
|
@premun the Apple-simulator job keeps failing. It isn't related to this pr, but I can't merge because of it. What can I do? |
|
Seems like the queue is backed up. I can try to merge myself. |
4 participants
index.html.Prompted by need to run blazor published apps by starting a webserver for them