Correcting ITextPointer when using cursor indicator #10281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
Kuldeep-MS,
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
singhashish-wpf
approved these changes
Jan 15, 2025
Contributor
singhashish-wpf
left a comment
singhashish-wpf
left a comment
There was a problem hiding this comment.
Backporting NETFX changes.
Contributor
|
So the only code change I can see is to call |
Member
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using accessibility option of text cursor indicator in
RichTextBoxsometimes lead to crashing applications due to Invariant assert here. AddingNormalize()call in changed location moves theendto thestartif this invariant assert fails and hence essentially corrects the cursor position.Customer Impact
Accessibility fix. Allowing the usage of text cursor indicator with RichTextBox.
Regression
None
Testing
Local Build Pass
Sample Application Testing
Risk
Low
Microsoft Reviewers: Open in CodeFlow