Add "SetTextualDefaultProperty = false" for MaskedTextBox#9709
Merged
LeafShi1 merged 3 commits intodotnet:mainfrom Aug 25, 2023
Merged
Add "SetTextualDefaultProperty = false" for MaskedTextBox#9709LeafShi1 merged 3 commits intodotnet:mainfrom
LeafShi1 merged 3 commits intodotnet:mainfrom
Conversation
56 tasks
lonitra
reviewed
Aug 18, 2023
Member
lonitra
left a comment
lonitra
left a comment
There was a problem hiding this comment.
Couple small comments, but otherwise LGTM!
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/MaskedTextBoxDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/MaskedTextBoxDesigner.cs
Outdated
Show resolved
Hide resolved
Contributor
|
What happens in this scenario in the OOP designer in the VS? |
Member
Author
I compared the OOP designer of VS, and found that the property setting SetTextualDefaultProperty was missing in the runtime repo, so I added this. After adding, the behavior of both sides will consistent. |
lonitra
added
the
ready-to-merge
ghost
removed
the
ready-to-merge
Contributor
|
Verified this PR in Winforms main branch for .NET 9.0, now the MaskedTextBox is supported in runtime, and the default Mask value is null:
9709-1.mp4 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #4908
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
The default Mask value of the MaskedTextBox is M_skedTextBox1
After
The default Mask value is null
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow