Port DataGridviewDesigner to runtime by Epica3055 · Pull Request #9677 · dotnet/winforms

Epica3055 · 2023-08-07T10:49:43Z

Related to #4908

Proposed changes

Port DataGridviewDesigner to runtime

Customer Impact

DataGridviewDesigner can be designed in runtime

Regression?

No

Risk

Minimal

Screenshots

Before

After

Test methodology

Manually (added DataGridviewDesigner to DemoConsole test app)

Test environment(s)

.Net 8.0.0-rc.1.23401.22

Microsoft Reviewers: Open in CodeFlow

src/System.Windows.Forms.Design/src/System.Windows.Forms.Design.csproj

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/BindingSourceDesigner.cs

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs

Tanya-Solyanik · 2023-08-21T19:15:35Z

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs

+        return true;
+    }
+
+    private class ListBoxItem


Please move this class to a dedicated file.

This is a small nested class, there are quite a few of this class in this PR.
Do really need to extract every one of them into a separate file?
Or did you mean: just extract every one of them out of the class but it still remain in the file? like this:

If these classes were nested before, they should stay nested. I meant extracting each small class into a small file.

Yes , there are nested before.

Could you please move these classes into dedicated files. You should name these new files like this - DataGridViewAddColumnDialog.ListBoxItem.cs. You will have to declare DataGridViewAddColumnDialog as partial class. See https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.ChildSubClass.cs for an example.

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs

src/System.Windows.Forms/src/System/Windows/Forms/DataGridView.cs

lonitra

👍

src/System.Windows.Forms.Primitives/src/System/Windows/Forms/Internals/DpiHelper.cs

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs

….com/Epica3055/winforms into Issue_4908_Port_DataGridViewDesigner

Tanya-Solyanik

Thank you!

Tanya-Solyanik · 2023-09-06T18:10:05Z

...em.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/TableLayoutPanelBehavior.cs

    private IServiceProvider serviceProvider; //cached to allow our behavior to get services
    private TableLayoutPanelResizeGlyph tableGlyph; //the glyph being resized
-    private DesignerTransaction resizeTransaction; //used to make size adjustements within transaction
+    private DesignerTransaction resizeTransaction; //used to make size adjustments within transaction


LocProj need to be updated to fix issue in CI https://dev.azure.com/dnceng/internal/_build/results?buildId=2266578&view=logs&j=c2111129-d6a3-58de-e667-00e5a0966c99&t=04624205-1088-500d-206a-392ceb108efa

We ported DataGridviewDesigner via #9677 LocProj need to be updated to fix issue in CI https://dev.azure.com/dnceng/internal/_build/results?buildId=2266578&view=logs&j=c2111129-d6a3-58de-e667-00e5a0966c99&t=04624205-1088-500d-206a-392ceb108efa

John-Qiao · 2023-09-15T07:10:33Z

Verified it in the main branch of Winforms repo for .Net 9.0, the DataGridviewDesigner can be designed in DemoConsole app runtime now.

ghost assigned Epica3055 Aug 7, 2023

Epica3055 mentioned this pull request Aug 7, 2023

Support designer capabilities at runtime #4908

Closed

56 tasks

Epica3055 changed the title ~~Issue 4908 port DataGridviewDesigner~~ port DataGridviewDesigner to runtime Aug 7, 2023

Epica3055 changed the title ~~port DataGridviewDesigner to runtime~~ Port DataGridviewDesigner to runtime Aug 7, 2023

ghost added the draft draft PR label Aug 7, 2023

Epica3055 force-pushed the Issue_4908_Port_DataGridViewDesigner branch from d1d524b to 015e4d3 Compare August 8, 2023 00:55

Epica3055 added a commit to Epica3055/winforms that referenced this pull request Aug 10, 2023

Port DataGridviewDesigner to runtime dotnet#9677

44a4d4e

Epica3055 force-pushed the Issue_4908_Port_DataGridViewDesigner branch from 015e4d3 to 44a4d4e Compare August 10, 2023 01:56

Epica3055 added a commit to Epica3055/winforms that referenced this pull request Aug 10, 2023

Port DataGridviewDesigner to runtime dotnet#9677

18b1fb8

Epica3055 force-pushed the Issue_4908_Port_DataGridViewDesigner branch 2 times, most recently from 18b1fb8 to c048d14 Compare August 10, 2023 10:25

Epica3055 added a commit to Epica3055/winforms that referenced this pull request Aug 10, 2023

Port DataGridviewDesigner to runtime dotnet#9677

c048d14

Epica3055 added a commit to Epica3055/winforms that referenced this pull request Aug 14, 2023

Port DataGridviewDesigner to runtime dotnet#9677

5b02b83

Epica3055 force-pushed the Issue_4908_Port_DataGridViewDesigner branch from c048d14 to 5b02b83 Compare August 14, 2023 09:34

Epica3055 added a commit to Epica3055/winforms that referenced this pull request Aug 14, 2023

Port DataGridviewDesigner to runtime dotnet#9677

5173a35

Epica3055 force-pushed the Issue_4908_Port_DataGridViewDesigner branch 8 times, most recently from cf300d4 to f0c305a Compare August 17, 2023 06:17

Epica3055 added a commit to Epica3055/winforms that referenced this pull request Aug 17, 2023

Port DataGridviewDesigner to runtime dotnet#9677

2a36dc0

Epica3055 force-pushed the Issue_4908_Port_DataGridViewDesigner branch from f0c305a to 5fc4031 Compare August 17, 2023 07:02

Epica3055 changed the base branch from feature/9.0 to main August 17, 2023 07:02

Epica3055 marked this pull request as ready for review August 17, 2023 07:58

Epica3055 requested a review from a team as a code owner August 17, 2023 07:58

ghost removed the draft draft PR label Aug 17, 2023

Tanya-Solyanik reviewed Aug 21, 2023

View reviewed changes

Epica3055 added 4 commits September 1, 2023 13:55

clean code

583e680

remove fields

04c218c

clean code

ad46577

fix conficts

330d2a4

Epica3055 force-pushed the Issue_4908_Port_DataGridViewDesigner branch from c091cc4 to 330d2a4 Compare September 1, 2023 06:07

fix CI errors

9932bec

lonitra previously approved these changes Sep 1, 2023

View reviewed changes

lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Sep 1, 2023

Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed ready-to-merge PRs that are ready to merge but worth notifying the internal team. labels Sep 1, 2023

Tanya-Solyanik reviewed Sep 1, 2023

View reviewed changes

src/System.Windows.Forms.Primitives/src/System/Windows/Forms/Internals/DpiHelper.cs Outdated Show resolved Hide resolved

Tanya-Solyanik reviewed Sep 1, 2023

View reviewed changes

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs Outdated Show resolved Hide resolved

Epica3055 dismissed lonitra’s stale review via 6a3790e September 5, 2023 07:22

ghost removed the waiting-author-feedback The team requires more information from the author label Sep 5, 2023

fix comments

95289e7

Epica3055 force-pushed the Issue_4908_Port_DataGridViewDesigner branch from 6a3790e to 95289e7 Compare September 5, 2023 07:25

Epica3055 and others added 4 commits September 6, 2023 09:47

Merge branch 'main' into Issue_4908_Port_DataGridViewDesigner

081f033

fix errors

2b7db12

Merge branch 'Issue_4908_Port_DataGridViewDesigner' of https://github…

0f9dce2

….com/Epica3055/winforms into Issue_4908_Port_DataGridViewDesigner

fix error

5034d3a

Tanya-Solyanik approved these changes Sep 7, 2023

View reviewed changes

Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Sep 7, 2023

Tanya-Solyanik merged commit 61b929a into dotnet:main Sep 7, 2023

ghost removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Sep 7, 2023

dreddy-work mentioned this pull request Sep 13, 2023

Update LocProj to help CI verification #9907

Merged

ghost locked as resolved and limited conversation to collaborators Oct 15, 2023

Epica3055 deleted the Issue_4908_Port_DataGridViewDesigner branch January 8, 2025 08:31

Conversation

Epica3055 commented Aug 7, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Customer Impact

Regression?

Risk

Screenshots

Before

After

Test methodology

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tanya-Solyanik Aug 21, 2023

Choose a reason for hiding this comment

Uh oh!

Epica3055 Aug 22, 2023

Choose a reason for hiding this comment

Uh oh!

Tanya-Solyanik Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

Epica3055 Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

Tanya-Solyanik Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lonitra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Tanya-Solyanik left a comment

Choose a reason for hiding this comment

Uh oh!

Tanya-Solyanik Sep 6, 2023

Choose a reason for hiding this comment

Uh oh!

John-Qiao commented Sep 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Epica3055 commented Aug 7, 2023 •

edited by ghost

Loading

Tanya-Solyanik Sep 1, 2023 •

edited

Loading