Merged
Conversation
This was referenced Jul 28, 2023
LeafShi1
requested review from
Epica3055,
SimonZhao888,
Tanya-Solyanik and
dreddy-work
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/PrintDialogDesigner.cs
Outdated
Show resolved
Hide resolved
dmitrii-drobotov
added
the
waiting-author-feedback
SimonZhao888
previously approved these changes
Jul 31, 2023
dmitrii-drobotov
added
waiting-author-feedback
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, I added only minor comments.
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/PrintDialogDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/PrintDialogDesigner.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
waiting-author-feedback
Tanya-Solyanik
approved these changes
Aug 1, 2023
Tanya-Solyanik
added
the
ready-to-merge
ghost
removed
the
ready-to-merge
Contributor
|
Verified this on feature/9.0 branch, now the default value of the property "UseEXDialog" for PrintDialog is true. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4908
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
The default value of the property "UseEXDialog" is false
After
The default value of the property "UseEXDialog" is true
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow