Skip to content

Port TableLayoutPanelDesigner, TabControlDesigner to runtime#9560

Merged
SimonZhao888 merged 9 commits intodotnet:feature/9.0from
SimonZhao888:Issue_8790_Add_TablelayoutPanelDesignerAndTabControlDesigner
Aug 1, 2023
Merged

Port TableLayoutPanelDesigner, TabControlDesigner to runtime#9560
SimonZhao888 merged 9 commits intodotnet:feature/9.0from
SimonZhao888:Issue_8790_Add_TablelayoutPanelDesignerAndTabControlDesigner

Conversation

@SimonZhao888
Copy link
Member

@SimonZhao888 SimonZhao888 commented Jul 25, 2023 •
edited by dmitrii-drobotov
Loading

Fixes #8790

Proposed changes

  • Port TabellayoutPanelDesigner, TabControlDesigner to runtime.

Customer Impact

  • TabellayoutPanelDesigner, TabControlDesigner can be designed in runtime.
  • Add TableLayoutPanel and TabControl to DemoConsole test app.

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

TabellayoutPanelDesigner, TabControlDesigner can not be designed test app.
image

After

TabellayoutPanelDesigner, TabControlDesigner can be designed in runtime.
TableLayoutPanelDesigner

Test methodology

  • Manually (added TabellayoutPanelDesigner and TabControlDesigner to DemoConsole test app)

Accessibility testing

Test environment(s)

  • .Net 8.0.100-preview.7.23363.2
  • Windows 10 Enterprise 22H2
Microsoft Reviewers: Open in CodeFlow

@SimonZhao888 SimonZhao888 requested a review from a team as a code owner July 25, 2023 08:08
@ghost ghost assigned SimonZhao888 Jul 25, 2023
@SimonZhao888 SimonZhao888 mentioned this pull request Jul 25, 2023
Closed
56 tasks
LeafShi1
LeafShi1 reviewed Jul 25, 2023
View reviewed changes
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/FlowPanelDesigner.cs
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

#nullable disable
Copy link
Member

@LeafShi1 LeafShi1 Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can enable nullability in the designer direcly, as the PR https://github.com/dotnet/winforms/pull/9408/files does

Copy link
Member Author

@SimonZhao888 SimonZhao888 Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many changes, first migrate the API, and then update them.

Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please keep migration changes separate from the nullability ones and create a second follow up PR

v-elnovikova
v-elnovikova reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@v-elnovikova v-elnovikova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Tanya-Solyanik Tanya-Solyanik added this to the .NET 9.0 milestone Jul 25, 2023
@dreddy-work dreddy-work changed the base branch from main to feature/9.0 July 25, 2023 19:07
@Tanya-Solyanik Tanya-Solyanik changed the title Port TabellayoutPanelDesigner, TabControlDesigner to runtime Port TablelayoutPanelDesigner, TabControlDesigner to runtime Jul 26, 2023
@Tanya-Solyanik Tanya-Solyanik changed the title Port TablelayoutPanelDesigner, TabControlDesigner to runtime Port TableLayoutPanelDesigner, TabControlDesigner to runtime Jul 26, 2023
@Tanya-Solyanik
Copy link
Contributor

Tanya-Solyanik commented Jul 26, 2023

@SimonZhao888 - did you copy this over from the VS repo?

Tanya-Solyanik
Tanya-Solyanik reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please address the test failures and follow up on nullability and other clean-up comments in the next PR.

...Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/TableLayoutPanelResizeGlyph.cs Outdated
{
get
{
return bounds;
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use expression-bodied properties, this could be done in the next PR or in a separate commit. Then we would have to merge this PR using a merge-commit rather than a squash to preserve history.

Copy link
Member Author

@SimonZhao888 SimonZhao888 Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Jul 26, 2023
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Jul 27, 2023
@SimonZhao888
Copy link
Member Author

SimonZhao888 commented Jul 27, 2023 •
edited
Loading

@SimonZhao888 - did you copy this over from the VS repo?

Yes, it's copy from VS repo.

LeafShi1
LeafShi1 previously approved these changes Jul 27, 2023
View reviewed changes
dmitrii-drobotov
dmitrii-drobotov previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@dmitrii-drobotov dmitrii-drobotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @SimonZhao888 - as a follow-up, we can also port StyleCollectionEditor which will be opened on "Edit Rows and Columns" button in TableLayoutPanelDesigner.

v-elnovikova
v-elnovikova approved these changes Jul 27, 2023
View reviewed changes
@dmitrii-drobotov dmitrii-drobotov added the waiting-author-feedback The team requires more information from the author label Jul 28, 2023
Tanya-Solyanik
Tanya-Solyanik reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd let Devendar comment if we should remove bug references or not.

@SimonZhao888 SimonZhao888 dismissed stale reviews from dmitrii-drobotov and LeafShi1 via 6ffe728 July 31, 2023 02:49
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Jul 31, 2023
dmitrii-drobotov
dmitrii-drobotov reviewed Jul 31, 2023
View reviewed changes
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabPageDesigner.cs Outdated
@@ -0,0 +1,50 @@
using System.ComponentModel.Design;
Copy link
Contributor

@dmitrii-drobotov dmitrii-drobotov Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license header is missing here

dkazennov
dkazennov approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@dkazennov dkazennov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Jul 31, 2023
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Aug 1, 2023
@SimonZhao888 SimonZhao888 merged commit 917e859 into dotnet:feature/9.0 Aug 1, 2023
@Philip-Wang01
Copy link
Contributor

Philip-Wang01 commented Aug 11, 2023

Verified this PR in feature/9.0 branch, now TabelLayoutPanelDesigner and TabControlDesigner are supported in runtime, we can modify TabeLlayoutPanelDesigner and TabControlDesigner in DemoConsole app by its some properties:
test9560

@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Epica3055 Epica3055 Awaiting requested review from Epica3055

@LeafShi1 LeafShi1 Awaiting requested review from LeafShi1

@gpetrou gpetrou Awaiting requested review from gpetrou

5 more reviewers

@dreddy-work dreddy-work dreddy-work left review comments

@dmitrii-drobotov dmitrii-drobotov dmitrii-drobotov left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@dkazennov dkazennov dkazennov approved these changes

@v-elnovikova v-elnovikova v-elnovikova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SimonZhao888 SimonZhao888

Labels

None yet

Projects

None yet

Milestone

.NET 9.0

Development

Successfully merging this pull request may close these issues.

9 participants

@SimonZhao888 @Tanya-Solyanik @Philip-Wang01 @gpetrou @dreddy-work @dmitrii-drobotov @dkazennov @v-elnovikova @LeafShi1