Port MonthCalendarDesigner to runtime#9536
Merged
dreddy-work merged 4 commits intodotnet:feature/9.0from Jul 26, 2023
LeafShi1:Issue_4908_Port_MonthCalendarDesigner
Merged
Port MonthCalendarDesigner to runtime#9536dreddy-work merged 4 commits intodotnet:feature/9.0from LeafShi1:Issue_4908_Port_MonthCalendarDesigner
dreddy-work merged 4 commits intodotnet:feature/9.0from
LeafShi1:Issue_4908_Port_MonthCalendarDesigner
Conversation
56 tasks
LeafShi1
requested review from
Epica3055,
SimonZhao888,
Tanya-Solyanik and
dmitrii-drobotov
SimonZhao888
previously approved these changes
Jul 21, 2023
Member
|
Please fix the error first. |
dreddy-work
reviewed
Jul 21, 2023
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/MonthCalendarDesigner.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Jul 21, 2023
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/MonthCalendarDesigner.cs
Outdated
Show resolved
Hide resolved
dreddy-work
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
dmitrii-drobotov
previously approved these changes
Jul 24, 2023
SimonZhao888
previously approved these changes
Jul 24, 2023
gpetrou
reviewed
Jul 24, 2023
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/MonthCalendarDesigner.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@LeafShi1 - could you please rebase this change against the .NET 9 branch |
LeafShi1
dismissed stale reviews from SimonZhao888 and dmitrii-drobotov
The base branch was changed.
Tanya-Solyanik
previously approved these changes
Jul 25, 2023
Member
Author
@Tanya-Solyanik After I rebase to NET9.0-Test branch, there are a lot of changes that are not belong to the current PR, but all PR checks are passed, can I complete this PR directly? |
Epica3055
previously approved these changes
Jul 25, 2023
SimonZhao888
previously approved these changes
Jul 25, 2023
LeafShi1
dismissed stale reviews from SimonZhao888 and Epica3055
The merge-base changed after approval.
Contributor
|
@LeafShi1 - the extra files indicate that the new .NET 9 branch is not up to date with main. Devendar is renaming the branch and after that it should take a merge from Main, then your PR will look clean |
Tanya-Solyanik
approved these changes
Jul 26, 2023
Tanya-Solyanik
added
the
ready-to-merge
ghost
removed
the
ready-to-merge
Member
|
Verified this PR in feature/9.0 branch, now MonthCalendarDesigner is supported in runtime, we can modify MonthCalendar in DemoConsole app by its some properties: |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4908
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow