Porting SplitContainerDesigner/SplitterPanelDesigner/SplitterDesigner.#9320
Merged
dreddy-work merged 3 commits intomainfrom Jun 21, 2023
Merged
Porting SplitContainerDesigner/SplitterPanelDesigner/SplitterDesigner.#9320dreddy-work merged 3 commits intomainfrom
dreddy-work merged 3 commits intomainfrom
Conversation
…eddy/PortSplitContainerDesigner
ghost
assigned
56 tasks
Tanya-Solyanik
approved these changes
Jun 21, 2023
Comment on lines
+162
to
+165
| _splitContainer.MouseDown -= new MouseEventHandler(OnSplitContainer); | ||
| _splitContainer.SplitterMoved -= new SplitterEventHandler(OnSplitterMoved); | ||
| _splitContainer.SplitterMoving -= new SplitterCancelEventHandler(OnSplitterMoving); | ||
| _splitContainer.DoubleClick -= new EventHandler(OnSplitContainerDoubleClick); |
Contributor
There was a problem hiding this comment.
Suggested change
| _splitContainer.MouseDown -= new MouseEventHandler(OnSplitContainer); | |
| _splitContainer.SplitterMoved -= new SplitterEventHandler(OnSplitterMoved); | |
| _splitContainer.SplitterMoving -= new SplitterCancelEventHandler(OnSplitterMoving); | |
| _splitContainer.DoubleClick -= new EventHandler(OnSplitContainerDoubleClick); | |
| _splitContainer.MouseDown -= OnSplitContainer; | |
| _splitContainer.SplitterMoved -= OnSplitterMoved; | |
| _splitContainer.SplitterMoving -= OnSplitterMoving; | |
| _splitContainer.DoubleClick -= OnSplitContainerDoubleClick; |
| { | ||
| BehaviorService.EnableAllAdorners(true); | ||
|
|
||
| var selMgr = (SelectionManager)GetService(typeof(SelectionManager)); |
Contributor
There was a problem hiding this comment.
Suggestion: selMan -> manager
This is applicable to this whole file
Member
Author
|
oops. it was on auto merge. These suggestions need to go in separate PR. I will see but @Tanya-Solyanik, if CTI is adding the unit tests, can you refer them to made these changes as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port missing designers. Ported from Framework. Comments and descriptions were directly taken from Framework.
SplitContainerDesignerSplitterPanelDesignerSplitterDesigner.Related to #4908
Fixes ##8749
Microsoft Reviewers: Open in CodeFlow