Refactor TabOrder to enable Nullability and replace ArrayList/HashTable#8400
Merged
lonitra merged 8 commits intodotnet:mainfrom Dec 22, 2022
Merged
Refactor TabOrder to enable Nullability and replace ArrayList/HashTable#8400lonitra merged 8 commits intodotnet:mainfrom
TabOrder to enable Nullability and replace ArrayList/HashTable#8400lonitra merged 8 commits intodotnet:mainfrom
Conversation
elachlan
changed the title
TabOrder to enable Nullability and replace ArrayList/HashTable
elachlan
commented
Dec 18, 2022
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Show resolved
Hide resolved
halgab
reviewed
Dec 18, 2022
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Outdated
Show resolved
Hide resolved
…n/TabOrder.cs Co-authored-by: halgab <[email protected]>
lonitra
reviewed
Dec 19, 2022
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TabOrder.cs
Show resolved
Hide resolved
lonitra
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
lonitra
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
lonitra
added
the
ready-to-merge
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several places where I had to do some unusual null checks where I think the code previously just assumed the they were not null. Such as any of the collections (
tabComplete, ect), orControl.Parent.Related: #8342, #8143, #8140
Microsoft Reviewers: Open in CodeFlow