added validation of the resource list for winforms and .Design assemblies#8393
Merged
Tanya-Solyanik merged 2 commits intodotnet:mainfrom Dec 20, 2022
Merged
added validation of the resource list for winforms and .Design assemblies#8393Tanya-Solyanik merged 2 commits intodotnet:mainfrom
Tanya-Solyanik merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
LGTM! Only suggestion would be if we can maintain the lists of icons, cursors, and manifest separately. Then use them in the other tests as well as this new test. That way we reduce the duplicated data. |
Contributor
Author
Thank you, good idea! This list is easier to dump and update than to match inline data to file names! This is how I tested your fix. I was going add the same to .Design assembly, where the list is generated off version before your change. |
Tanya-Solyanik
force-pushed
the
test-resources
branch
from
7addb7a to
50ce282
Compare
Tanya-Solyanik
changed the title
Contributor
|
LGTM! This is great! |
Tanya-Solyanik
added
waiting-review
lonitra
added
the
ready-to-merge
Contributor
Author
Tanya-Solyanik
removed
waiting-review
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that we do not add any unexpected resources.
Removed test that validated presence of manifest because it's superseded by the test that matches available resources against the expected list.
Expected lists are dumped out from assemblies before the change that introduced regular expressions to the project files.
Microsoft Reviewers: Open in CodeFlow