Add misc Design tests and fix a NullRef bug #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsd4yr
suggested changes
Apr 16, 2019
| if (options?.Parent == null) | ||
| { | ||
| DesignerOptions designerOptions = CompatibilityOptions; | ||
| if (designerOptions != null) |
Contributor
There was a problem hiding this comment.
If options is null, then this evaluation is now true. What happens then options reaches CreateOptionCollection(options, "DesignerOptions", designerOptions);?
Contributor
Author
There was a problem hiding this comment.
OK... looks like I accidentally subclassed the wrong thing so weren't great here.
Codecov Report
@@ Coverage Diff @@
## master #807 +/- ##
==================================================
+ Coverage 27.4977% 27.59476% +0.09706%
==================================================
Files 1055 1061 +6
Lines 291188 291414 +226
Branches 38518 38521 +3
==================================================
+ Hits 80070 80415 +345
+ Misses 207060 206939 -121
- Partials 4058 4060 +2
|
zsd4yr
approved these changes
Apr 19, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #806