Skip to content

Conversation

@ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Sep 19, 2025

Related #10773

Proposed changes

  • Adds coverage for BindingNavigatorDesigner.
Microsoft Reviewers: Open in CodeFlow

@ricardobossan ricardobossan self-assigned this Sep 19, 2025
@ricardobossan ricardobossan requested a review from a team as a code owner September 19, 2025 00:00
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Sep 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive unit test coverage for the BindingNavigatorDesigner class to improve test coverage and ensure proper functionality of the designer component.

Key Changes

  • Adds a new test file BindingNavigatorDesignerTests.cs with 181 lines of test code
  • Implements tests for component initialization, item siting, and component change event handling
  • Uses parameterized tests to verify navigation item property handling across multiple scenarios

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 98.31933% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.14894%. Comparing base (5dcf17d) to head (b100253).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13883         +/-   ##
===================================================
+ Coverage   77.12069%   77.14894%   +0.02824%     
===================================================
  Files           3273        3274          +1     
  Lines         644919      645038        +119     
  Branches       47693       47701          +8     
===================================================
+ Hits          497366      497640        +274     
+ Misses        143849      143709        -140     
+ Partials        3704        3689         -15     
Flag Coverage Δ
Debug 77.14894% <98.31933%> (+0.02824%) ⬆️
integration 19.02665% <ø> (+0.04145%) ⬆️
production 52.00964% <ø> (+0.05452%) ⬆️
test 97.41286% <98.31933%> (+0.00029%) ⬆️
unit 49.42147% <ø> (+0.01563%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ricardobossan ricardobossan merged commit 54eae4a into dotnet:main Sep 23, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Sep 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants