Add test for design binding picker #13536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeafShi1
force-pushed
the
Add_test_for_DesignBindingPicker
branch
from
b46fb99 to
8f4c5b8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13536 +/- ##
===================================================
+ Coverage 76.59683% 76.59848% +0.00164%
===================================================
Files 3230 3231 +1
Lines 639157 639185 +28
Branches 47295 47302 +7
===================================================
+ Hits 489574 489606 +32
+ Misses 146007 145995 -12
- Partials 3576 3584 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new unit test class to verify that the DesignBindingPicker control and its subcomponents are initialized correctly.
- Adds
DesignBindingPickerTestscovering constructor setup, panel child controls, and a helper for control-type checks. - Introduces a private helper method
ContainsType<T>to simplify asserting presence of child controls by type.
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
Member
ricardobossan
left a comment
ricardobossan
left a comment
There was a problem hiding this comment.
Please consider adding, in this or another PR, tests for the remaining public and protected methods: Pick, OnVisibleChanged, OnGotFocus and RescaleConstantsForDpi.
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
ricardobossan
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
LeafShi1
added
the
waiting-review
KlausLoeffelmann
approved these changes
Jun 9, 2025
Member
KlausLoeffelmann
left a comment
KlausLoeffelmann
left a comment
There was a problem hiding this comment.
If it passes, it's OK to merge IMO!
dotnet-policy-service
bot
removed
the
waiting-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Microsoft Reviewers: Open in CodeFlow