Skip to content

Conversation

@ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Apr 30, 2025

Related #10773

Proposed changes

  • Adds coverage for public properties and methods of ComponentTray.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests

Test environment(s)

  • 10.0.100-preview.3.25201.16
Microsoft Reviewers: Open in CodeFlow

Related dotnet#10773

- Adds coverage for `ComponentTray`.

- None

- No

- Minimal

- Unit tests

- 10.0.100-preview.3.25201.16
@ricardobossan ricardobossan self-assigned this Apr 30, 2025
@ricardobossan
Copy link
Member Author

Drafted because will add more tests.

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.96868%. Comparing base (5f9458e) to head (2ad5df2).
Report is 68 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13396         +/-   ##
===================================================
+ Coverage   62.72868%   62.96868%   +0.24000%     
===================================================
  Files           1561        1563          +2     
  Lines         159997      160132        +135     
  Branches       14918       14919          +1     
===================================================
+ Hits          100364      100833        +469     
+ Misses         58857       58524        -333     
+ Partials         776         775          -1     
Flag Coverage Δ
Debug 62.96868% <100.00000%> (+0.24000%) ⬆️
integration 11.33844% <ø> (+0.00418%) ⬆️
production 41.26602% <ø> (+0.34682%) ⬆️
test 95.71205% <100.00000%> (+0.00909%) ⬆️
unit 38.67313% <ø> (+0.35097%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Apr 30, 2025
@ricardobossan ricardobossan changed the title - Adds coverage for ComponentTray Adds coverage for ComponentTray Apr 30, 2025
@ricardobossan ricardobossan marked this pull request as ready for review May 8, 2025 02:19
@ricardobossan ricardobossan requested a review from a team as a code owner May 8, 2025 02:19
@ricardobossan ricardobossan added waiting-review This item is waiting on review by one or more members of team and removed draft draft PR labels May 8, 2025
@ricardobossan ricardobossan marked this pull request as draft May 8, 2025 18:19
@ricardobossan ricardobossan marked this pull request as ready for review May 8, 2025 18:25
Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) added 2 commits May 9, 2025 15:38
@KlausLoeffelmann
Copy link
Member

In my opinion, the component try is nothing we should officially support in the runtime. I would not like to take this. Closing this. Feel free to reopen, if you disagree. @merriemcgaw FYI.

@ricardobossan, sorry for the effort you already did.
But this is way too VS WinForms Designer-related, and we should exclude those things or at least have a discussion in our weekly meetings about those.

@Olina-Zhang, @LeafShi1, @merriemcgaw FYI.

@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Jun 11, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants