Skip to content

Add unit tests for EditorServiceContext #13273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tanya-Solyanik merged 5 commits into from
Apr 10, 2025
Merged

Add unit tests for EditorServiceContext #13273

Tanya-Solyanik merged 5 commits into from
Apr 10, 2025

Conversation

@MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Apr 9, 2025 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  • Add unit test file: EditorServiceContextTests.cs for public method of the EditorServiceContext.cs.
Microsoft Reviewers: Open in CodeFlow

@MelonWang1 MelonWang1 requested a review from a team as a code owner April 9, 2025 07:52
@codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.36364% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.18641%. Comparing base (378a836) to head (4af81aa).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #13273         +/-   ##
===================================================
+ Coverage   62.09218%   62.18641%   +0.09423%     
===================================================
  Files           1555        1556          +1     
  Lines         159260      159366        +106     
  Branches       14849       14854          +5     
===================================================
+ Hits           98888       99104        +216     
+ Misses         59648       59511        -137     
- Partials         724         751         +27
Flag Coverage Δ
Debug 62.18641% <96.36364%> (+0.09423%) ⬆️
integration 11.29955% <ø> (+0.57611%) ⬆️
production 40.31990% <ø> (+0.11824%) ⬆️
test 95.66723% <96.36364%> (+0.00095%) ⬆️
unit 37.67686% <ø> (+0.02385%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardobossan ricardobossan requested a review from Copilot April 10, 2025 02:04
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

@ricardobossan ricardobossan mentioned this pull request Apr 10, 2025
Open
ricardobossan
ricardobossan requested changes Apr 10, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM!

ricardobossan
ricardobossan previously approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

Tanya-Solyanik
Tanya-Solyanik approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik enabled auto-merge (squash) April 10, 2025 20:11
@Tanya-Solyanik Tanya-Solyanik merged commit de252e0 into dotnet:main Apr 10, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 10, 2025
@MelonWang1 MelonWang1 deleted the Add_unit_tests_for_EditorServiceContext branch April 11, 2025 02:14
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@ricardobossan ricardobossan ricardobossan left review comments

+1 more reviewer

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MelonWang1 MelonWang1

Labels

area-test coverage

Projects

None yet

Milestone

10.0 Preview4

Development

Successfully merging this pull request may close these issues.

3 participants

@MelonWang1 @Tanya-Solyanik @ricardobossan