Skip to content

Conversation

@Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Mar 13, 2025

Related #10773

Proposed changes

  • Add unit test file: ControlCommandSetTests.cs for public methods and 2 protected methods of the ControlCommandSet.cs.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 92.66055% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.42520%. Comparing base (df745d6) to head (7b13805).
Report is 90 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13130         +/-   ##
===================================================
+ Coverage   61.32538%   61.42520%   +0.09981%     
===================================================
  Files           1543        1548          +5     
  Lines         158339      158588        +249     
  Branches       14745       14758         +13     
===================================================
+ Hits           97102       97413        +311     
+ Misses         60539       60472         -67     
- Partials         698         703          +5     
Flag Coverage Δ
Debug 61.42520% <92.66055%> (-13.88816%) ⬇️
integration 10.73289% <ø> (-8.17760%) ⬇️
production 39.30591% <ø> (-36.00745%) ⬇️
test 95.67418% <92.66055%> (∅)
unit 36.74564% <ø> (-37.65504%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tanya-Solyanik Tanya-Solyanik added the waiting-review This item is waiting on review by one or more members of team label Mar 13, 2025
@LeafShi1 LeafShi1 removed the waiting-review This item is waiting on review by one or more members of team label Mar 20, 2025
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added only a minor comment, otherwise looks good. @LeafShi1 - please merge if you approve this PR.

@LeafShi1 LeafShi1 merged commit 5d908dd into dotnet:main Mar 28, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Mar 28, 2025
@Olina-Zhang Olina-Zhang deleted the UnitTest_ControlCommandSet branch March 28, 2025 07:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants