Add unit tests for StatusCommandUI #13121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeafShi1
reviewed
Mar 12, 2025
...tem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StatusCommandUITests.cs
Outdated
Show resolved
Hide resolved
LeafShi1
reviewed
Mar 12, 2025
Member
LeafShi1
left a comment
LeafShi1
left a comment
There was a problem hiding this comment.
LGTM with one little suggestion
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the public method of StatusCommandUI to verify correct interactions with the command service under various input scenarios.
- Introduces tests for null components, standard controls, custom components, and explicit rectangle parameters.
- Verifies that command invocations are made with the correct rectangle values based on the input.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13121 +/- ##
===================================================
+ Coverage 61.28152% 61.35586% +0.07433%
===================================================
Files 1541 1547 +6
Lines 158281 158482 +201
Branches 14743 14752 +9
===================================================
+ Hits 96997 97238 +241
+ Misses 60587 60542 -45
- Partials 697 702 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, I added some minot comments
...tem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StatusCommandUITests.cs
Outdated
Show resolved
Hide resolved
...tem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StatusCommandUITests.cs
Show resolved
Hide resolved
...tem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StatusCommandUITests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow