Add code coverage for DataGridViewColumnTypeEditor #13084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13084 +/- ##
===================================================
+ Coverage 61.02797% 61.31589% +0.28791%
===================================================
Files 1539 1542 +3
Lines 158039 158326 +287
Branches 14721 14744 +23
===================================================
+ Hits 96448 97079 +631
+ Misses 60897 60549 -348
- Partials 694 698 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Zheng-Li01
added
the
waiting-review
Contributor
There was a problem hiding this comment.
PR Overview
This PR adds a new unit test file to validate the public methods of DataGridViewColumnTypeEditor.
- Added tests to verify proper initialization and default property values.
- Included tests for GetEditStyle returning the expected UITypeEditorEditStyle.
- Covered scenarios in EditValue where essential services or context instances are missing.
Reviewed Changes
| File | Description |
|---|---|
| src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DataGridViewColumnTypeEditorTests.cs | New test file verifying initialization, GetEditStyle, and EditValue behaviors |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DataGridViewColumnTypeEditorTests.cs:40
- Consider adding a test case for the scenario where both a non-null IWindowsFormsEditorService and a valid context instance are provided, verifying any additional behavior of EditValue beyond simply returning the original value.
Mock<IServiceProvider> serviceProviderMock = new();
ricardobossan
added
the
waiting-author-feedback
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/DataGridViewColumnTypeEditorTests.cs
Show resolved
Hide resolved
Zheng-Li01
removed
the
waiting-author-feedback
Tanya-Solyanik
approved these changes
Mar 11, 2025
dotnet-policy-service
bot
removed
the
waiting-review
Zheng-Li01
deleted the
Add_code_coverage_for_DataGridViewColumnTypeEditor
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Add unit test file: DataGridViewColumnTypeEditor.cs for public methods of the DataGridViewColumnTypeEditor.cs
Microsoft Reviewers: Open in CodeFlow