Add unit test for ToolStripInSituService #13021
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13021 +/- ##
===================================================
+ Coverage 75.97321% 76.11337% +0.14016%
===================================================
Files 3265 3276 +11
Lines 643286 643879 +593
Branches 47431 47460 +29
===================================================
+ Hits 488725 490078 +1353
+ Misses 150991 150230 -761
- Partials 3570 3571 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
John-Qiao
added
the
waiting-review
LeafShi1
requested changes
Feb 25, 2025
...dows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripInSituServiceTests.cs
Outdated
Show resolved
Hide resolved
...dows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripInSituServiceTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
removed
the
waiting-review
Tanya-Solyanik
added
waiting-author-feedback
LeafShi1
reviewed
Mar 10, 2025
...dows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripInSituServiceTests.cs
Show resolved
Hide resolved
...dows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripInSituServiceTests.cs
Show resolved
Hide resolved
LeafShi1
removed
the
waiting-review
Olina-Zhang
added
the
waiting-author-feedback
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a unit test file for ToolStripInSituService to verify the proper behavior of its properties, methods, and disposal logic.
- Introduces unit tests for ensuring proper disposal of designers and unsubscribing from services.
- Verifies service retrieval and proper response to component removal events.
Comments suppressed due to low confidence (2)
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripInSituServiceTests.cs:98
- [nitpick] The test method name 'GetEditWindow_ReturnsZero_WhenNoDesignerIsNotNull' contains a double negative that may be unclear. Consider renaming it to 'GetEditWindow_ReturnsZero_WhenDesignerIsNull' for clarity.
public void GetEditWindow_ReturnsZero_WhenNoDesignerIsNotNull()
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripInSituServiceTests.cs:72
- [nitpick] The test method name 'ToolStripKeyBoardService_ReturnsServiceInstance' uses 'KeyBoard' with an unexpected casing; consider renaming it to 'ToolStripKeyboardService_ReturnsServiceInstance' to match the typical casing in the codebase.
public void ToolStripKeyBoardService_ReturnsServiceInstance()
Member
ricardobossan
left a comment
ricardobossan
left a comment
There was a problem hiding this comment.
Except for small comments, all LGTM!
...dows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripInSituServiceTests.cs
Show resolved
Hide resolved
...dows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripInSituServiceTests.cs
Show resolved
Hide resolved
Contributor
|
@ricardobossan or @LeafShi1 - could you please pick up this PR? |
ricardobossan
pushed a commit
to ricardobossan/winforms
that referenced
this pull request
Apr 7, 2025
Tanya-Solyanik
pushed a commit
that referenced
this pull request
Apr 16, 2025
* Add coveerage for ToolStripInSituService, completing PR #13021 --------- Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow