Add ShortcutKeysEditor tests and fix some bugs #1297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
Jul 8, 2019
Contributor
RussKie
left a comment
RussKie
left a comment
There was a problem hiding this comment.
Can you please clarify what the bug was?
src/System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/ShortcutKeysEditor.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/ShortcutKeysEditor.cs
Show resolved
Hide resolved
hughbe
commented
Jul 8, 2019
| IWindowsFormsEditorService edSvc = | ||
| (IWindowsFormsEditorService)provider.GetService(typeof(IWindowsFormsEditorService)); | ||
| if (edSvc != null) | ||
| if (provider.GetService(typeof(IWindowsFormsEditorService)) is IWindowsFormsEditorService edSvc) |
Contributor
Author
| get | ||
| { | ||
| if (((Keys)currentValue & Keys.KeyCode) == 0) | ||
| if (currentValue is Keys currentKeys && (currentKeys & Keys.KeyCode) == 0) |
Contributor
Author
| originalValue = currentValue = value; | ||
|
|
||
| Keys keys = (Keys)value; | ||
| Keys keys = value is Keys ? (Keys)value : Keys.None; |
Contributor
Author
Contributor
Author
If you called |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1296
Contributes to #817