Skip to content

Conversation

@Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Feb 18, 2025

Related #10773

Proposed changes

  • Add unit test file: ToolStripDesignerUtilsTests.cs for public methods of the ToolStripDesignerUtils.cs.
  • Enable nullability in ToolStripDesignerUtilsTests.cs.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93695%. Comparing base (8ef1b9c) to head (7f77704).
Report is 37 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12967          +/-   ##
====================================================
+ Coverage   75.97321%   96.93695%   +20.96374%     
====================================================
  Files           3265        1220        -2045     
  Lines         643286      356932      -286354     
  Branches       47431        5528       -41903     
====================================================
- Hits          488725      345999      -142726     
+ Misses        150991       10092      -140899     
+ Partials        3570         841        -2729     
Flag Coverage Δ
Debug 96.93695% <100.00000%> (+20.96374%) ⬆️
integration ?
production ?
test 96.93695% <100.00000%> (-0.01625%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripDesignerUtilsTests.cs:116

  • [nitpick] The 'InvalidateSelection_InvokesInvalidate' test only asserts that no exception is thrown. Consider adding an assertion or spy to verify that the expected invalidation logic is actually executed.
act.Should().NotThrow();

@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Feb 19, 2025
@Olina-Zhang Olina-Zhang removed the waiting-author-feedback The team requires more information from the author label Feb 20, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 0e15742 into dotnet:main Feb 22, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Feb 22, 2025
@Olina-Zhang Olina-Zhang deleted the UnitTest_ToolStripDesignerUtils branch February 24, 2025 00:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants