Add unit tests for ToolStripMenuItemCodeDomSerializer #12883
Merged
+78
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12883 +/- ##
===================================================
- Coverage 76.09601% 76.08859% -0.00743%
===================================================
Files 3255 3257 +2
Lines 642880 642204 -676
Branches 47315 47286 -29
===================================================
- Hits 489206 488644 -562
+ Misses 150112 150015 -97
+ Partials 3562 3545 -17
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
ricardobossan
left a comment
ricardobossan
left a comment
There was a problem hiding this comment.
Other than small comments, all LGTM!
...esign/tests/UnitTests/System/Windows/Forms/Design/ToolStripMenuItemCodeDomSerializerTests.cs
Outdated
Show resolved
Hide resolved
...esign/tests/UnitTests/System/Windows/Forms/Design/ToolStripMenuItemCodeDomSerializerTests.cs
Outdated
Show resolved
Hide resolved
ricardobossan
added
the
waiting-author-feedback
MelonWang1
removed
the
waiting-author-feedback
Contributor
|
@ricardobossan @MelonWang1 - these are reasonable basic tests, but is it possible to add some specific serialization cases? |
LeafShi1
pushed a commit
to LeafShi1/winforms
that referenced
this pull request
Mar 6, 2025
* Add unit tests for ToolStripMenuItemCodeDomSerializer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow