Skip to content

Conversation

@MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Jan 13, 2025

Related #10773

Proposed changes

  • Add unit test CommandSetTests.cs for public method of the CommandSet.
  • Enable nullability in CommandSetTests.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.21095%. Comparing base (9780820) to head (29464f5).
Report is 36 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12769         +/-   ##
===================================================
+ Coverage   76.18717%   76.21095%   +0.02378%     
===================================================
  Files           3193        3199          +6     
  Lines         640306      640488        +182     
  Branches       47237       47227         -10     
===================================================
+ Hits          487831      488122        +291     
+ Misses        148942      148836        -106     
+ Partials        3533        3530          -3     
Flag Coverage Δ
Debug 76.21095% <91.66667%> (+0.02378%) ⬆️
integration 18.15955% <ø> (-0.01856%) ⬇️
production 50.14904% <ø> (+0.02073%) ⬆️
test 97.03843% <91.66667%> (+0.01530%) ⬆️
unit 47.55250% <ø> (+0.01018%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small comment, all LGTM!

@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label Jan 15, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 17, 2025
@LeafShi1 LeafShi1 added waiting-review This item is waiting on review by one or more members of team waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jan 20, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 21, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Tanya-Solyanik Tanya-Solyanik merged commit 77ec5c9 into dotnet:main Jan 21, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 21, 2025
@MelonWang1 MelonWang1 deleted the Add_unit_tests_for_CommandSet branch January 22, 2025 02:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants