Remove Clipboard.Clear From Some Tests #12755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12755 +/- ##
===================================================
- Coverage 76.15360% 76.15209% -0.00151%
===================================================
Files 3192 3192
Lines 640256 640249 -7
Branches 47237 47237
===================================================
- Hits 487578 487563 -15
+ Misses 149168 149166 -2
- Partials 3510 3520 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Jan 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #12738 (comment)
Clipboard.Clear was added to some Clipboard tests to help with flakyness in #11527. At the time it was unclear why we were experiencing increased flaky Clipboard tests locally, but in #12738 moved test that was added in JSON PR that was accessing Clipboard without being under same collection as other clipboard tests. Since this is now under same collection Clipboard.Clear should not be necessary so removing.
Microsoft Reviewers: Open in CodeFlow