Skip to content

Conversation

@John-Qiao
Copy link
Contributor

@John-Qiao John-Qiao commented Jan 10, 2025

Related #10773

Proposed changes

  • Add unit test ImageCollectionCodeDomSerializerTests.cs for public Deserialize() method of the ImageCollectionCodeDomSerializer.
  • Enable nullability in ImageCollectionCodeDomSerializerTests.cs.
Microsoft Reviewers: Open in CodeFlow

@John-Qiao John-Qiao requested a review from a team as a code owner January 10, 2025 10:35
@ricardobossan
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.18261%. Comparing base (084e6d0) to head (6f71e6a).
Report is 55 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12753         +/-   ##
===================================================
+ Coverage   76.03186%   76.18261%   +0.15075%     
===================================================
  Files           3181        3194         +13     
  Lines         639670      640364        +694     
  Branches       47215       47238         +23     
===================================================
+ Hits          486353      487846       +1493     
+ Misses        149797      148984        -813     
- Partials        3520        3534         +14     
Flag Coverage Δ
Debug 76.18261% <100.00000%> (+0.15075%) ⬆️
integration 18.15555% <ø> (-0.02073%) ⬇️
production 50.11318% <ø> (+0.29119%) ⬆️
test 97.02362% <100.00000%> (-0.00554%) ⬇️
unit 47.51526% <ø> (+0.47235%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Jan 10, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 13, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 836ac76 into dotnet:main Jan 13, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants