Skip to content

Conversation

@MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Jan 8, 2025

Related #10773

Proposed changes

  • Add unit test LinkAreaEditor.LinkAreaUITests.cs for public properties and method of the LinkAreaEditor.LinkAreaUI.
  • Enable nullability in LinkAreaEditor.LinkAreaUITests.cs.
Microsoft Reviewers: Open in CodeFlow

@MelonWang1 MelonWang1 requested a review from a team as a code owner January 8, 2025 01:46
@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.13612%. Comparing base (a3da2c9) to head (96d1eab).
Report is 18 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12725         +/-   ##
===================================================
+ Coverage   76.11619%   76.13612%   +0.01993%     
===================================================
  Files           3187        3188          +1     
  Lines         639990      640051         +61     
  Branches       47229       47234          +5     
===================================================
+ Hits          487136      487310        +174     
+ Misses        149322      149217        -105     
+ Partials        3532        3524          -8     
Flag Coverage Δ
Debug 76.13612% <100.00000%> (+0.01993%) ⬆️
integration 18.17176% <ø> (+0.00527%) ⬆️
production 50.03462% <ø> (+0.03971%) ⬆️
test 97.02550% <100.00000%> (+0.00050%) ⬆️
unit 47.26372% <ø> (+0.03513%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@Tanya-Solyanik Tanya-Solyanik merged commit ffab8c8 into dotnet:main Jan 9, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 9, 2025
@MelonWang1 MelonWang1 deleted the Add_unit_tests_for_LinkAreaEditor.LinkAreaUI branch January 10, 2025 01:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants