Add unit tests for ControlDesigner.ControlDesignerAccessibleObject #12664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12664 +/- ##
===================================================
+ Coverage 76.02394% 76.12135% +0.09741%
===================================================
Files 3180 3186 +6
Lines 639659 639965 +306
Branches 47216 47227 +11
===================================================
+ Hits 486294 487150 +856
+ Misses 149851 149297 -554
- Partials 3514 3518 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardobossan
requested changes
Dec 20, 2024
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, I added some minor comments only.
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Tanya-Solyanik
approved these changes
Jan 7, 2025
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Thank you, looks good!
MelonWang1
deleted the
Add_unit_tests_for_ControlDesigner.ControlDesignerAccessibleObject
branch
ricardobossan
pushed a commit
to ricardobossan/winforms
that referenced
this pull request
Jan 9, 2025
…otnet#12664) Related dotnet#10773 Proposed changes Add unit test ControlDesigner.ControlDesignerAccessibleObjectTests.cs for public properties and method of the ControlDesigner.ControlDesignerAccessibleObject. Enable nullability in ControlDesigner.ControlDesignerAccessibleObjectTests.cs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Add unit test ControlDesigner.ControlDesignerAccessibleObjectTests.cs for public properties and method of the ControlDesigner.ControlDesignerAccessibleObject.
Enable nullability in ControlDesigner.ControlDesignerAccessibleObjectTests.cs.
Microsoft Reviewers: Open in CodeFlow