Skip to content

Conversation

@MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Nov 21, 2024

Related #10773

Proposed changes

  • Add unit test ToolStripActionListTests.cs for public properties and method of the ToolStripActionList.
  • Enable nullability in ToolStripActionList.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.76949%. Comparing base (dc4314e) to head (7f4dd5c).
Report is 20 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12525         +/-   ##
===================================================
+ Coverage   75.74163%   75.76949%   +0.02786%     
===================================================
  Files           3157        3160          +3     
  Lines         636098      636037         -61     
  Branches       47003       46989         -14     
===================================================
+ Hits          481791      481922        +131     
+ Misses        150846      150652        -194     
- Partials        3461        3463          +2     
Flag Coverage Δ
Debug 75.76949% <100.00000%> (+0.02786%) ⬆️
integration 18.17337% <ø> (-0.01186%) ⬇️
production 49.34011% <ø> (+0.03072%) ⬆️
test 97.04813% <100.00000%> (+0.00283%) ⬆️
unit 46.55744% <ø> (+0.03551%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comment, LGTM

@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team and removed waiting-review This item is waiting on review by one or more members of team labels Nov 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Nov 22, 2024
ricardobossan
ricardobossan previously approved these changes Nov 22, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Nov 22, 2024
@ricardobossan ricardobossan dismissed their stale review November 23, 2024 01:03

new comments to be addressed

@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Nov 25, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit ee114a5 into dotnet:main Nov 25, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 25, 2024
@MelonWang1 MelonWang1 deleted the Add_unit_tests_for_ToolStripActionList branch November 26, 2024 02:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants