Skip to content

Conversation

@MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Nov 7, 2024

Related #10773

Proposed changes

  • Add unit test ContextMenuStripActionListTests.cs for public properties and method of the ContextMenuStripActionList.
  • Enable nullability in ContextMenuStripActionList.
Microsoft Reviewers: Open in CodeFlow

@MelonWang1 MelonWang1 requested a review from a team as a code owner November 7, 2024 08:08
@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.05103%. Comparing base (f3dbf39) to head (9f908d1).
Report is 20 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12442          +/-   ##
====================================================
+ Coverage   75.65340%   97.05103%   +21.39762%     
====================================================
  Files           3150        1163        -1987     
  Lines         635830      351919      -283911     
  Branches       47020        5289       -41731     
====================================================
- Hits          481027      341541      -139486     
+ Misses        151351        9633      -141718     
+ Partials        3452         745        -2707     
Flag Coverage Δ
Debug 97.05103% <100.00000%> (+21.39762%) ⬆️
integration ?
production ?
test 97.05103% <100.00000%> (+0.02024%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Nov 7, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Nov 8, 2024
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM.

@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Nov 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Nov 12, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lonitra lonitra merged commit fc53ec3 into dotnet:main Nov 13, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 13, 2024
@MelonWang1 MelonWang1 deleted the Add_unit_tests_for_ContextMenuStripActionList branch November 15, 2024 01:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants