Skip to content

Conversation

@Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented Oct 22, 2024

Related #10773

Proposed changes

  • Add unit test ToolStripContentPanelDesignerTests.cs for public properties and method of the ToolStripContentPanelDesigner.
  • Enable nullability in ToolStripContentPanelDesignerTests.cs.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.58677%. Comparing base (89e6bb9) to head (b412578).
Report is 12 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12366         +/-   ##
===================================================
- Coverage   75.64669%   75.58677%   -0.05993%     
===================================================
  Files           3119        3136         +17     
  Lines         635392      636020        +628     
  Branches       46933       47025         +92     
===================================================
+ Hits          480653      480747         +94     
- Misses        151277      151813        +536     
+ Partials        3462        3460          -2     
Flag Coverage Δ
Debug 75.58677% <100.00000%> (-0.05993%) ⬇️
integration 18.24448% <ø> (-0.03792%) ⬇️
production 49.11566% <ø> (-0.08446%) ⬇️
test 97.02732% <100.00000%> (+0.00042%) ⬆️
unit 46.09831% <ø> (-0.07304%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@Epica3055 Epica3055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added minor comments

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Oct 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 23, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Oct 23, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit 3d725e6 into dotnet:main Oct 23, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Oct 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants