Skip to content

Conversation

@Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Oct 21, 2024

Related #10773

Proposed changes

  • Add unit test DataGridViewComponentPropertyGridSiteTests.cs for public methods of the DataGridViewComponentPropertyGridSite.
  • Enable nullability in DataGridViewComponentPropertyGridSiteTests.cs.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.58493%. Comparing base (89e6bb9) to head (5bb6b8d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12357         +/-   ##
===================================================
- Coverage   75.64669%   75.58493%   -0.06177%     
===================================================
  Files           3119        3136         +17     
  Lines         635392      636017        +625     
  Branches       46933       47026         +93     
===================================================
+ Hits          480653      480733         +80     
- Misses        151277      151834        +557     
+ Partials        3462        3450         -12     
Flag Coverage Δ
Debug 75.58493% <100.00000%> (-0.06177%) ⬇️
integration 18.24976% <ø> (-0.03265%) ⬇️
production 49.11180% <ø> (-0.08832%) ⬇️
test 97.02729% <100.00000%> (+0.00038%) ⬆️
unit 46.06704% <ø> (-0.10431%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Oct 22, 2024
@Olina-Zhang Olina-Zhang removed the waiting-author-feedback The team requires more information from the author label Oct 23, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than colleagues comments, all LGTM

@lonitra lonitra merged commit e964588 into dotnet:main Oct 23, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 23, 2024
@Olina-Zhang Olina-Zhang deleted the UnitTest_DataGridViewComponentPropertyGridSite branch October 24, 2024 07:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants